Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useCustomCodeActionMenu settings behave oddly when resetting default #158587

Closed
gjsjohnmurray opened this issue Aug 19, 2022 · 1 comment · Fixed by #158617 or #158629
Closed

useCustomCodeActionMenu settings behave oddly when resetting default #158587

gjsjohnmurray opened this issue Aug 19, 2022 · 1 comment · Fixed by #158617 or #158629
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@gjsjohnmurray
Copy link
Contributor

gjsjohnmurray commented Aug 19, 2022

Type: Bug

Go to Settings Editor, search for 'customcodeactionmenu', then use gearwheel menu on the first item to reset its default. Observe that the checkbox of the second item changes. Repeat the reset on the first item and the second one changes again.

junk

VS Code version: Code - Insiders 1.71.0-insider (28f604d, 2022-08-19T05:17:14.894Z)
OS version: Windows_NT x64 10.0.22000
Modes:
Sandboxed: Yes

@gjsjohnmurray
Copy link
Contributor Author

Secondary comment: I think the second setting is poorly named. Setting the option true disables headers. I think it would be better named something like editor.experimental.useCustomCodeActionMenu.showHeaders with a default of true rather than editor.experimental.useCustomCodeActionMenu.toggleHeaders with a default of false.

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 19, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the August 2022 milestone Aug 19, 2022
@rzhao271 rzhao271 assigned justschen and unassigned rzhao271 Aug 19, 2022
@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Aug 19, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 22, 2022
@meganrogge meganrogge added the verified Verification succeeded label Aug 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
5 participants