Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support toggles in the quick pick, adopt in terminal run recent command #158616

Merged
merged 7 commits into from Aug 22, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 19, 2022

Part of #156179
Fixes #156322

The part marked HACK is the only part I'm not sure about, but I couldn't see a way to do it otherwise without IQuickPick being in browser. We could have an IBrowserQuickPick which extends IQuickPick but it might not be worth it vs the current solution.

This also improves how pinned items are filtered and shown.

cc @meganrogge

Recording 2022-08-19 at 11 19 21

@Tyriar Tyriar added this to the August 2022 milestone Aug 19, 2022
@Tyriar Tyriar self-assigned this Aug 19, 2022
@Tyriar Tyriar merged commit 9b507bc into main Aug 22, 2022
@Tyriar Tyriar deleted the tyriar/156179-quickinput-find branch August 22, 2022 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Use Fuzzy Search" button toggle - a weird UI pattern
2 participants