Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have UI expose data in VariablePresentationHint #158724

Open
zobo opened this issue Aug 22, 2022 · 1 comment
Open

Have UI expose data in VariablePresentationHint #158724

zobo opened this issue Aug 22, 2022 · 1 comment
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@zobo
Copy link
Contributor

zobo commented Aug 22, 2022

Hi all!

Besides wanting this myself, I get user requests here and there (xdebug/vscode-php-debug#819) to provide visual feedback on whether a field displayed in the Variables pane is private, protected or public. This is all reported within VariablePresentationHint with lots more information. I understand from this old issue #50331 that VS Code doesn't implement this and that adding support similar to VS would be quite an effort (a lot of icon combinations) however how about a simpler approach?

Currently when hovering on a variable name, we get the type name:

image

Could we just add the other info, if its present? Maybe
(visibility _attributes_ kind) type

Maybe we can call on some of the other DA authors and maintainers to see if they are receiving similar feedback?

Thanks again for all the hard work!
Damjan

@gjsjohnmurray
Copy link
Contributor

Maybe switch (maybe optionally) to use a rich hover which adds lines/sections for the kind and attributes properties of VariablePresentationHint as well as for visibility.

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Aug 22, 2022
@weinand weinand assigned roblourens and unassigned weinand Aug 22, 2022
@roblourens roblourens added the feature-request Request for new features or functionality label Aug 23, 2022
@roblourens roblourens added this to the Backlog milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants