Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial run of disabling and enabling activity bar badges #158781

Merged
merged 6 commits into from Nov 18, 2022

Conversation

lramos15
Copy link
Member

This PR allows for enabling and disabling the view badges via a context menu similar to Pin.

This is a rough draft PR with a few ugly hacks as I'm not familiar with this feature area

@lramos15
Copy link
Member Author

@sandy081 Not sure if you want to put aside time to discuss and review this PR together. Moving to backlog for now as this was just a proof of concept.

@lramos15 lramos15 modified the milestones: September 2022, Backlog Sep 26, 2022
@sandy081
Copy link
Member

Please schedule a time to discuss about this.

sandy081
sandy081 previously approved these changes Nov 17, 2022
Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lramos15 lramos15 marked this pull request as ready for review November 18, 2022 17:53
@lramos15 lramos15 merged commit 823fe5d into main Nov 18, 2022
@lramos15 lramos15 deleted the lramos15/disableActivityBadges branch November 18, 2022 19:00
@lramos15 lramos15 modified the milestones: Backlog, November 2022 Nov 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants