Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When there are several definitions in the peek view, arrow should point to the correct word #158887

Merged
merged 3 commits into from Aug 24, 2022

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Aug 23, 2022

Fixes #158871. The new behavior after merging the new changes from yesterday is as follows. The peek view is not hidden behind the target line.

sticky-scroll-peekview

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit but I also think the behaviour can be improved. The recording shows that peek reveals behind sticky scroll, e.g it slightly overlap and IMO we should have a solution where the target line and the arrow are visible

Screenshot 2022-08-24 at 09 15 14

@aiday-mar aiday-mar requested a review from jrieken August 24, 2022 07:42
@aiday-mar aiday-mar merged commit 1bdec7a into main Aug 24, 2022
@aiday-mar aiday-mar deleted the aiday/issue158871 branch August 24, 2022 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When several definitions revealed, the arrow in the peek view should point to the correct element
3 participants