Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Editor: "Accept All Changes from Left" command discoverability #158890

Open
lszomoru opened this issue Aug 23, 2022 · 7 comments
Open

Merge Editor: "Accept All Changes from Left" command discoverability #158890

lszomoru opened this issue Aug 23, 2022 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality merge-editor
Milestone

Comments

@lszomoru
Copy link
Member

Testing #158819

I would love for the "Accept All Changes from ..." command to be more discoverable as currently it is in the ... context menu. Have we ever considered lifting it as a primary action in the editor toolbar? Could we put a checkbox in the editor toolbar right before the "Input 1" label, and when that is clicked all changes from the side are accepted?

image

@hediet hediet added under-discussion Issue is under discussion for relevance, priority, approach merge-editor labels Aug 23, 2022
@hediet
Copy link
Member

hediet commented Aug 23, 2022

@daviddossett @isidorn

@hediet hediet added this to the September 2022 milestone Aug 23, 2022
@isidorn
Copy link
Contributor

isidorn commented Sep 7, 2022

+1 for icon and a spot as a primary action

@daviddossett
Copy link
Contributor

How about these surfaced as dedicated icon buttons in place of the "..." menu?

CleanShot 2022-09-07 at 15 12 11@2x

@hediet
Copy link
Member

hediet commented Sep 8, 2022

Maybe a tri-state checkbox would be nice (initially none taken, when you click it it will take all, when you only select a few, it will be "dirty").
The <-> confuses me though.

@isidorn
Copy link
Contributor

isidorn commented Sep 9, 2022

Shouldn't the double check icon make sense here? ✔️ ✔️
Sort of like "take all"? Just an idea...

@daviddossett
Copy link
Contributor

Good point, I like that 👍

@isidorn
Copy link
Contributor

isidorn commented Sep 14, 2022

This just came up in our user study and the participant clearly said they would appreciate this as a primary action.
fyi @stevencl

@hediet hediet added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Sep 27, 2022
@hediet hediet modified the milestones: September 2022, October 2022 Sep 27, 2022
@hediet hediet modified the milestones: October 2022, November 2022 Oct 24, 2022
@hediet hediet modified the milestones: November 2022, December 2022 Nov 28, 2022
@hediet hediet modified the milestones: January 2023, On Deck Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality merge-editor
Projects
None yet
Development

No branches or pull requests

4 participants