-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Editor: "Accept All Changes from Left" command discoverability #158890
Comments
+1 for icon and a spot as a primary action |
Maybe a tri-state checkbox would be nice (initially none taken, when you click it it will take all, when you only select a few, it will be "dirty"). |
Shouldn't the double check icon make sense here? ✔️ ✔️ |
Good point, I like that 👍 |
This just came up in our user study and the participant clearly said they would appreciate this as a primary action. |
Testing #158819
I would love for the "Accept All Changes from ..." command to be more discoverable as currently it is in the
...
context menu. Have we ever considered lifting it as a primary action in the editor toolbar? Could we put a checkbox in the editor toolbar right before the "Input 1" label, and when that is clicked all changes from the side are accepted?The text was updated successfully, but these errors were encountered: