Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit sessions shows modal dialog #159014

Closed
jrieken opened this issue Aug 24, 2022 · 1 comment · Fixed by #160464
Closed

Edit sessions shows modal dialog #159014

jrieken opened this issue Aug 24, 2022 · 1 comment · Fixed by #160464
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded

Comments

@jrieken
Copy link
Member

jrieken commented Aug 24, 2022

Testing #158798

  • Continue from web inside desktop
  • Let the window sit
  • Install update (which restarts the App)
  • 🧀 you are instantly greeted with a modal dialog (I wasn't even in that window of VS Code)

Ideas

  • don't use a modal but the custom modal overlay which is more friendly and doesn't steep focus
  • don't show this when my local changes are no different to those on the server

Screenshot 2022-08-24 at 09 26 13

@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue labels Aug 24, 2022
@joyceerhl joyceerhl added this to the September 2022 milestone Aug 24, 2022
@joyceerhl
Copy link
Contributor

don't use a modal but the custom modal overlay which is more friendly and doesn't steep focus

Is the custom modal overlay the same thing as the custom modal dialog, i.e.

await this.dialogService.show(Severity.Warning, 'my message', ['my options'], { custom: true });

don't show this when my local changes are no different to those on the server

👍 I filed #159689 for this.

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 26, 2022
@jrieken jrieken added the verified Verification succeeded label Sep 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
3 participants