Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve authentication story for edit sessions #159078

Closed
Tracked by #160047
joyceerhl opened this issue Aug 24, 2022 · 1 comment · Fixed by #160364
Closed
Tracked by #160047

Improve authentication story for edit sessions #159078

joyceerhl opened this issue Aug 24, 2022 · 1 comment · Fixed by #160364
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Aug 24, 2022

@jrieken had the following feedback while setting up for testing #158798:

  1. There is no Sign In entry or badge in the accounts menu badge, only a command palette option to Sign In
  2. Expected to see edit sessions as an option when enabling settings sync. More broadly, expected a unified 'Sign In to VS Code' experience, which is also feedback that @Tyriar had
  3. The 'Signed In' group for existing auth sessions is confusing--it means that there's an existing auth session for that auth provider in general, but can look like the user already used that auth provider to sign in for edit sessions (@lramos15's feedback in Create New Codespace fails if the current repo was cloned using SSH #159287)
@joyceerhl joyceerhl added the bug Issue identified by VS Code Team member as probable bug label Aug 24, 2022
@joyceerhl joyceerhl added this to the September 2022 milestone Aug 24, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 8, 2022
@meganrogge meganrogge added the verification-steps-needed Steps to verify are needed for verification label Sep 30, 2022
@joyceerhl
Copy link
Contributor Author

Verification:

  1. First turn off edit sessions from the account menu if you had it turned on before
  2. Make some changes in insiders.vscode.dev/github/microsoft/vscode
  3. Run the Continue Working On command
  4. Verify you are asked whether you want to bring your working changes with you using edit sessions
  5. Pick an account to use with edit sessions
  6. Run the Continue Working On command again
  7. Verify that you aren't asked again about bringing your working changes with you

@joyceerhl joyceerhl removed the verification-steps-needed Steps to verify are needed for verification label Oct 3, 2022
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Oct 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants