Sticky Scroll : when several outline models are available, choose the one spanning the biggest total range #159305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiday-mar
added
editor-sticky-scroll
bug
|
Why do we merge this in next release? |
|
@heartacker the PR has not yet been thoroughly tested and reviewed so we leave some time to be sure it behaves correctly and does not break anything else. This change will be placed into next month's stable release. You can however view the new modifications on Insiders once the PR is merged. |
jrieken
reviewed
Aug 29, 2022
src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts
Outdated
Show resolved
Hide resolved
jrieken
reviewed
Aug 29, 2022
src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts
Outdated
Show resolved
Hide resolved
jrieken
requested changes
Aug 29, 2022
src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts
Outdated
Show resolved
Hide resolved
jrieken
previously approved these changes
Aug 30, 2022
jrieken
approved these changes
Aug 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular it fixes #159136
To test:
Open a launch.json file
Enable sticky scroll and verify that the sticky lines stuck to the top of the view port do not correspond to the outline model in the bottom-right pannel