Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ITerminalInstance.runRecent into its own file #159626

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Move ITerminalInstance.runRecent into its own file #159626

merged 1 commit into from
Aug 31, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 30, 2022

Fixes #159618

The improvements to ITerminalInstance were a nice side effect of this

@Tyriar Tyriar added this to the September 2022 milestone Aug 30, 2022
@Tyriar Tyriar requested a review from meganrogge August 30, 2022 22:54
@Tyriar Tyriar self-assigned this Aug 30, 2022
meganrogge
meganrogge approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test, but LGTM 👍🏼

@Tyriar Tyriar merged commit a9e28d5 into main Aug 31, 2022
@Tyriar Tyriar deleted the tyriar/159618 branch August 31, 2022 12:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
September 2022
Development

Successfully merging this pull request may close these issues.

Move ITerminalInstance.runRecent into its own class
2 participants
@Tyriar @meganrogge