Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #149309 #159822

Merged
merged 1 commit into from Sep 2, 2022
Merged

fix #149309 #159822

merged 1 commit into from Sep 2, 2022

Conversation

sandy081
Copy link
Member

@sandy081 sandy081 commented Sep 2, 2022

fix #149309

  • wait until an extension's dependencies and packed extensions are completely installed even if they are getting installed from a different extension
  • make sure not to wait if there is a cycle

@sandy081 sandy081 self-assigned this Sep 2, 2022
@sandy081 sandy081 mentioned this pull request Sep 2, 2022
Closed
@VSCodeTriageBot VSCodeTriageBot added this to the September 2022 milestone Sep 2, 2022
@gjsjohnmurray gjsjohnmurray mentioned this pull request Sep 2, 2022
Closed
5 tasks
@sandy081 sandy081 merged commit eebf615 into main Sep 2, 2022
@sandy081 sandy081 deleted the sandy081/partial-dragonfly branch September 2, 2022 07:09
@tschaffter tschaffter mentioned this pull request Sep 2, 2022
Closed
@jeanp413 jeanp413 mentioned this pull request Sep 13, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

@ProKashif ProKashif ProKashif approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
September 2022
Development

Successfully merging this pull request may close these issues.

Extension fails activation when installing extensions from cli that have a common dependency
4 participants
@sandy081 @jrieken @ProKashif @VSCodeTriageBot