Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make it so that the search function in the file explorer descends into closed folders #159909

Closed
scott-parkhill opened this issue Sep 2, 2022 · 5 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@scott-parkhill
Copy link

Currently, when you use ctrl+f to search for files in your project, it will only match files that are currently visually visible, i.e. in folders that are not collapsed. But if you collapse a folder and try to search for a file, it comes up empty. I want the search feature to, when enter is pressed, recursively descend into the folders and open them up to the point of any matches.

It's currently super frustrating because I want ctrl+f in the explorer to work and try it so much and it just returns nothing. Then what I end up doing is going to the terminal and doing find . -name <filename>, then manually go through the relevant directories and open them up and find the file I want to open. The explorer's ctrl+f should do this for you.

@IllusionMH
Copy link
Contributor

/duplicate of #66971

@VSCodeTriageBot VSCodeTriageBot added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 2, 2022
@VSCodeTriageBot
Copy link
Collaborator

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2022
@scott-parkhill
Copy link
Author

@IllusionMH I did look at that issue, and I could be wrong but it doesn't really seem like a duplicate. That person seems to be talking about the filtering functionality not working accordingly, while the behaviour and feature I described has nothing to do specifically with the filtering capability but with the search function in its entirety. In fact, that linked issue is rather confusing, I'm not entirely sure what that poster is getting at.

@IllusionMH
Copy link
Contributor

IllusionMH commented Sep 2, 2022

Ctrl+F in File Explorer (from your description I assume that you are talking about this view) and in lists(trees) in general is substitute for "filter as you type" feature that basically had two modes highlight matches and navigate them with / or hide anything that doesn't (fuzzy)match typed string.

So replacing filter as you type with explicit search widget don't resolve root cause - to find all matching tree items you need to resolve(expand) everything recursively which is ultimately requested in #66971 (and I agree that that's issue has really long description) which is tracking issue for this kind of requests.

@scott-parkhill
Copy link
Author

Okay, thank you for the clarification!

@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants