Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[f#] Block comment not colored as comment #16

Closed
bpasero opened this issue Nov 16, 2015 · 5 comments
Closed

[f#] Block comment not colored as comment #16

bpasero opened this issue Nov 16, 2015 · 5 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
Backlog

Comments

@bpasero
Copy link
Member

bpasero commented Nov 16, 2015

Using the block comment in F# adds the following around 'samplesLabel':

let mutable (*samplesLabel*) : System.Windows.Forms.Label = null

This is however not colored as a comment in VS Code.
@chrisdias chrisdias added the bug Issue identified by VS Code Team member as probable bug label Nov 16, 2015
@egamma
Copy link
Member

egamma commented Nov 30, 2015

@aeschli can you consult with the F# extension what should be done here, e.g., should we adopt the grammar from atom?

@egamma egamma added the languages-basic Basic language support issues label Nov 30, 2015
@aeschli aeschli changed the title F#: Block comment not colored as comment [f#] Block comment not colored as comment Nov 30, 2015
@aeschli
Copy link
Contributor

aeschli commented Nov 30, 2015

We're using the grammar from https://github.com/ionide/ionide-fsharp.
Our grammar is up to date on version 1.4.11.

@aeschli
Copy link
Contributor

aeschli commented Nov 30, 2015

Filed as https://github.com/ionide/ionide-fsharp/issues/186

@aeschli aeschli added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Nov 30, 2015
@egamma egamma modified the milestone: Backlog Dec 10, 2015
@unional
Copy link

unional commented Feb 10, 2017

Seems like upstream is fixed 🌷
https://github.com/ionide/ionide-atom-fsharp/issues/186#issuecomment-272727360

@aeschli aeschli closed this as completed Feb 22, 2017
@aeschli aeschli reopened this Feb 22, 2017
@aeschli
Copy link
Contributor

aeschli commented Feb 22, 2017

Comment is still not correctly colored. Closing this issue as it is tracked in ionide/ionide-atom-fsharp#186

@aeschli aeschli closed this as completed Feb 22, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@egamma @bpasero @chrisdias @unional @aeschli