Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backups - 💄 #160478

Merged
merged 1 commit into from Sep 9, 2022
Merged

backups - 💄 #160478

merged 1 commit into from Sep 9, 2022

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Sep 9, 2022

No description provided.

@bpasero bpasero enabled auto-merge (squash) September 9, 2022 05:03
@VSCodeTriageBot VSCodeTriageBot added this to the September 2022 milestone Sep 9, 2022
Copy link

@ProKashif ProKashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please PR description as well.

try {
await Promises.unlink(legacyBackupWorkspacesPath);
} catch (error) {
// ignore

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be more appropriate.

Suggested change
// ignore
console.error(error)

@bpasero bpasero merged commit f54c237 into main Sep 9, 2022
@bpasero bpasero deleted the ben/minor-smelt branch September 9, 2022 08:15
mjbvz pushed a commit to mjbvz/vscode that referenced this pull request Sep 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants