Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add audio cue for task end and terminal bell #160828

Merged
merged 9 commits into from Sep 15, 2022
Merged

add audio cue for task end and terminal bell #160828

merged 9 commits into from Sep 15, 2022

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Sep 13, 2022 •
edited

fix #141506
fix #47711

@meganrogge meganrogge self-assigned this Sep 13, 2022
@meganrogge meganrogge added this to the September 2022 milestone Sep 13, 2022
@meganrogge meganrogge changed the title add audio cue for task end add audio cue for task end and terminal bell Sep 13, 2022
@meganrogge meganrogge marked this pull request as draft September 13, 2022 18:16
@meganrogge meganrogge marked this pull request as ready for review September 13, 2022 18:31
@Tyriar Tyriar requested a review from hediet September 13, 2022 19:48
@meganrogge
Copy link
Contributor Author

not sure what's happening w the test failure - it passes locally

hediet
hediet approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@hediet hediet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@meganrogge meganrogge enabled auto-merge (squash) September 15, 2022 13:13
@meganrogge meganrogge merged commit 001f7d5 into main Sep 15, 2022
@meganrogge meganrogge deleted the merogge/task-sound branch September 15, 2022 16:34
benibenj pushed a commit that referenced this pull request Sep 15, 2022
@meganrogge @benibenj
add audio cue for task end and terminal bell (#160828)
1b9b26b
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar left review comments

@hediet hediet hediet approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
September 2022
3 participants
@meganrogge @Tyriar @hediet