Extension Badge represents number of outdated and reloadrequired extensions

[benibenj]

Whatever style of extension "notification center" we decide to go for, we'll want the badge number to represent also reload required extensions.
I'm making this a seperate PR in advance such that it is easier to review.

[sandy081]

Another idea would be to add reloadStatus property to IExtension

vscode/src/vs/workbench/contrib/extensions/common/extensions.ts

Line 41 in 25ab33e

export interface IExtension {

like outdated property. Then we do not need the two new APIs you added.

[benibenj]

The reason why I did not add a reloadRequired property to IExtension is because we need the running extensions which has to be fetched asynchronously. This means the getter would have to be async and for every extension that we check if a reload is required, an async call is made. Due to this, it's better to have two API calls. One that is sync if the client already has the running extensions, and one that is async, for which the async call has to be performed only once instead of for each extension which would be slow.

[sandy081]

That's right and this is the reason ReloadAction maintains a state of runtime extensions so that they can be accessed sync. ExtensionWorkbenchService can do the same and maintain a state of runtime extensions. Doing so, the service can return the reload state of each extension using the existing state of runtime extension when asked for.

Ideally IExtensionService shall provide sync access to runtime extensions given that it has a change event when they are changed. Then, we do not need to maintain this state in our services. I will talk to AlexD about this later and see if we can get the sync API, until then lets move runtime extensions state to ExtensionWorkbenchService and add reloadStatus property to IExtension

[benibenj]

I pushed some changes, but I would prefer to wait until we have sync access to the running extensions before merging. Otherwise, there is either the possibility for a race condition (current situation) or we have to add events which I prefer not to. I think it should be possible to make the running extensions accessible synchronously. Let's discuss with Alex.