Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backslash is not escaped by define key binding #16108

Merged
merged 1 commit into from Dec 5, 2016

Conversation

ypresto
Copy link
Contributor

@ypresto ypresto commented Nov 27, 2016

When defining keybinding using backslash key (with Define Keybinding feature), it will insert unescaped backslash:

"key": "shift+cmd+\",

This PR fixes it!

@mention-bot
Copy link

@ypresto, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima, @jrieken and @joaomoreno to be potential reviewers.

@msftclas
Copy link

Hi @ypresto, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@ypresto ypresto changed the title Fix backslash is unescaped by define key binding Fix backslash is not escaped by define key binding Nov 27, 2016
@alexdima
Copy link
Member

alexdima commented Dec 5, 2016

@ypresto Nice! Thank you for the contribution! ❤️

@alexdima alexdima added this to the November 2016 milestone Dec 5, 2016
@alexdima alexdima merged commit edee513 into microsoft:master Dec 5, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants