chore: use plugin executable for utility process on macOS #161102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing insiders build https://monacotools.visualstudio.com/Monaco/_build/results?buildId=185574&view=results |
deepak1556
force-pushed
the
robo/update_entitlements
branch
from
7d46bda
to
0035dae
Compare
|
Actually this is not urgent, lets make this change after extension host utility process is made default in stable so that we don't have to maintain a separate change in distro. |
bpasero
previously approved these changes
Sep 16, 2022
|
Can we ship this as long as there is still that setting to disable utility process? |
|
We could do it potentially if I add back the changes to
Thoughts ? |
|
Yeah sounds good to me. |
deepak1556
force-pushed
the
robo/update_entitlements
branch
from
0035dae
to
b0f6f07
Compare
deepak1556
changed the title
|
Builds are looking good 🚀 |
bpasero
approved these changes
Sep 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the executable used on macOS to spawn the extension host process from
Code Helper.apptoCode Helper (Plugin).appusing theallowLoadingUnsignedLibrariescapability of the utility process.This allows us to remove some privileged entitlements from the main application bundle which will protect the main process from loading any unsigned libraries or from dyld linker processing the
DYLD_variables that can be used to inject code into the process.