Cell attachment cleanup tool improvement in diff editor #161132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jupyter notebook support
attachmentsinnbdocument.cellbut this concept doesn't exist in notebook, thus the ipynb extension stores this special data in cell metadata. Our attachment cleanup tool will listen to content changes and make sure the attachment stored in the cell metadata is cleared/restored when attachment links in cell content changed.However this doesn't work well in diff editor, when users try to revert attachment link change in cell content, the diff editor is not aware that we need to restore some of the metadata properties. This PR is an attempt to allow serializers to mark which metadata properties are related to cell content and should be restored when cell content is being modified in the diff editor.
The long term solution might be that we delegate the diffing work to serializers, serializers can build up mappings between attachment link, attachment data and cell diffs, so it can listen to cell content changes in modified editor and restore cell metadata from the original document properly.