New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert hiding some notebook toolbars #161136
Conversation
Sorry for the breakage and thanks for the fix
Is that something that you can express with a config-context key? Each config-value is exposed as context key named |
Hm, we already have two registrations in that menu, based on that config context key, so the label can change: I guess I'm not sure why it wasn't being rerendered before |
This is a real pain to debug, but I guess this is just because the setting is not officially registered, it's an undocumented setting. @rebornix should we just decide right now whether to officially register this setting (can still be "experimental") or delete it? |
1626ee9
to
5e0ed1f
Compare
MenuWorkbenchToolBar
in BetweenCellToolBar"
In notebook standup we decided that supporting normal hiding doesn't really work in notebooks for most toolbars. They don't feel like normal menus, if we want to customize these things it should work differently. I reverted it for every toolbar except the title toolbar where it works quite well. Reverting the IW toolbar also fixed the issue we saw with the run button always showing inside a |
We need to rerender the menu when thsi setting changes, because it determines which actionViewItem is used. cc @jrieken @rebornix
This reverts commit 517448a.