Don't fire empty updates when a pausable emitter is resumed #161269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Looks like a good change but I wonder how we got there. The CKS shouldn't fire events when nothing changes, there are check like this one. @roblourens do you recall/know how the underlying event got triggered?
|
setContext was never called. We are just calling |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this because this code buffers context key change events, but sometimes none actually changed:
https://github.com/9at8/vscode/blob/0884315fc01e6a46927c36c662c41b19d1dbe0be/src/vs/workbench/contrib/notebook/browser/view/cellParts/cellContextKeys.ts#L123-L141
The alternative would be to duplicate all of those same checks outside of the
bufferChangeEventscall, which might lead to duplication but I can live with, but it doesn't seem like there is ever a reason to fire an empty update like this.