Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge editor dialogs feedback #161554

Open
bpasero opened this issue Sep 23, 2022 · 0 comments
Open

Merge editor dialogs feedback #161554

bpasero opened this issue Sep 23, 2022 · 0 comments
Assignees
@hediet
Labels
merge-editor polish Cleanup and polish issue
Milestone
On Deck

Comments

@bpasero
Copy link
Member

bpasero commented Sep 23, 2022

Testing the new experience, some minor feedback on the dialogs I noticed.

This is a nice dialog: uses capital casing for buttons, has a short main message (in bold) and some details (in non bold):

image

This dialog has quite a long main button, no capital casing and maybe could have a shorter main message and some details for more explanation?

image

This dialog is 👍

image
@bpasero bpasero added polish Cleanup and polish issue merge-editor labels Sep 23, 2022
@hediet hediet modified the milestones: September 2022, October 2022 Sep 27, 2022
@hediet hediet modified the milestones: October 2022, November 2022 Oct 24, 2022
@hediet hediet modified the milestones: November 2022, December 2022 Nov 28, 2022
@hediet hediet modified the milestones: January 2023, On Deck Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hediet hediet

Labels
merge-editor polish Cleanup and polish issue
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
2 participants
@bpasero @hediet