Enforce all properties on output matchers #161779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enforces output matchers will always have an anchor, offset and length as otherwise the matcher will search every line which could be thousands of lines. This also runs the free port issue only on a failed command, we can amend the xterm.js script to exit with error if needed to support this as it should do that anyway. Fixes #161758
meganrogge
approved these changes
Sep 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces output matchers will always have an anchor, offset and length as otherwise the matcher will search every line which could be thousands of lines. This also runs the free port issue only on a failed command, we can amend the xterm.js script to exit with error if needed to support this as it should do that anyway.
Fixes #161758