Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killing a process on a port should not result in a notification #162217

Closed
connor4312 opened this issue Sep 28, 2022 · 1 comment · Fixed by #163951
Closed

Killing a process on a port should not result in a notification #162217

connor4312 opened this issue Sep 28, 2022 · 1 comment · Fixed by #163951
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders terminal-quick-fix ux User experience issues
Milestone

Comments

@connor4312
Copy link
Member

connor4312 commented Sep 28, 2022

Testing #161846

  1. Kill a process listening on a conflicting port
  2. Notice you get a notification that persists until you choose to close it

Since terminal prompts often live right on the bottom of the window, this can be particularly annoying as it can get in the way of the prompt, which then requires a click

I'm not sure the best fix for this, I think some indicator of success is useful but I don't think the loudness of a notification is appropriate

@Tyriar
Copy link
Member

Tyriar commented Sep 28, 2022

The notification is just a placeholder until we come up with some good feedback probably through the UX sync. I think removing it outright without an alternative would be a bad idea since we're killing a process.

image

@Tyriar Tyriar added the ux User experience issues label Sep 28, 2022
@Tyriar Tyriar added this to the October 2022 milestone Sep 28, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders terminal-quick-fix ux User experience issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants