Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS Walkthrough: extension icon sticks out amongst built-in icons #163007

Closed
daviddossett opened this issue Oct 7, 2022 · 1 comment · Fixed by #163498
Closed

JS Walkthrough: extension icon sticks out amongst built-in icons #163007

daviddossett opened this issue Oct 7, 2022 · 1 comment · Fixed by #163498
Assignees
@DanielRosenwasser
Labels
getting-started insiders-released Patch has been released in VS Code Insiders

Comments

@daviddossett
Copy link
Contributor

Is there a way to use a codicon instead of an extension PNG? It feels out of place amongst built-in walkthroughs that can use a codicon.

CleanShot 2022-10-07 at 14 27 23@2x

cc @DanielRosenwasser since we chatted about this before
@DanielRosenwasser DanielRosenwasser self-assigned this Oct 13, 2022
@DanielRosenwasser DanielRosenwasser mentioned this issue Oct 13, 2022
Merged
@DanielRosenwasser
Copy link
Member

Conversation over at #157965 (comment)

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DanielRosenwasser DanielRosenwasser

Labels
getting-started insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow walkthroughs to specify icons. DanielRosenwasser/vscode
3 participants
@DanielRosenwasser @daviddossett @VSCodeTriageBot