-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks: Run Task
command performance is slow in monorepo
#163143
Comments
This is already fixed in insiders |
This is not fixed in 1.72.2.
Does that mean this was closed because it wasn't successfully reproduced, and should be reopened? Previously, there was some sort of cache of recently used tasks that I could start before the automatically collected ones showed up. Now the task menu doesn't show up until they have all loaded. I'm using a remote container/local docker setup with a monorepo and this makes tasks unusable. I counted a full minute of lag on opening the task window. I see 30 tasks in that list, and I wonder if this is fetching a lot of items and cutting them off by priority. I'm also thinking that this could have something to do with clean handling of addons acting weird. I noticed that some of the menu items are NX generators with different parameters. One possible solution would be to organize auto-generated tasks under menu items in the main task menu (as well as pinned and recently used tasks) and to start a thread fetching auto-generated tasks while that runs. In general though, the list of auto-detected tasks doesn't change often for me, and I'm surprised I don't see more caching on this. |
@david-morris thanks for the info. Can you pls see if you can repro the issue in the insider's build? |
The latest version of vscode doesn't fix it, and the reason for no reply after that is just that I don't know how to reproduce it in vscode insiders. I thought it was equivalent to a feature of jetbrains webstorm, but since I couldn't provide a reproduction, I stopped using this feature and didn't reopen the issue. |
@meganrogge unable to reproduce in insiders 👍 So I'm having trouble understanding your release cadence, is there something I can read to understand how long bugfixes will stay in insiders before being released? I only posted this because I couldn't find anything on this except the "Date" field on the about page. It takes well over a half hour to get an insider build running my container, so I'm hoping to reduce release-hopping. |
Type: Performance Issue
I have 100+ modules in a pnpm monorepo in production and I have to run npm scripts across modules every day, but when I try to use
Run Task
to display npm scripts that have been run before, it waits a few seconds for it to appear , I also encountered this problem in a project in production environment.What I want to know is: when using the command, will the whole monorepo be scanned? If you do, it will be really slow.
Update
When I use the latest Visual Studio Code - Insiders, the performance is normal, but even with all plugins disabled, the problem persists in the stable version of VSCode, I suspect it may be caused by some cache, but I'm not sure how to debug
VS Code version: Code 1.72.0 (64bbfbf, 2022-10-04T23:20:39.912Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Process Info
Workspace Info
Extensions (25)
A/B Experiments
The text was updated successfully, but these errors were encountered: