Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapped lines w screen reader #163229

Merged
merged 33 commits into from Oct 21, 2022
Merged

wrapped lines w screen reader #163229

merged 33 commits into from Oct 21, 2022

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Oct 10, 2022

Fixes #95428

  • when a screen reader is attached, the editor is forced to compute wrapping points using the advanced strategy (the one using the DOM) and without any wrapping indent.
  • wrapping is then also enabled in the textarea and the idea is that the textarea's wrapping points will match the editor's wrapping points.
  • there are many details to get right, such as the tab size in the textarea, scrolling it such that VoiceOver's thick black box lines up with the editor content, turning wrapping off when IME is active, etc.

@meganrogge meganrogge added this to the October 2022 milestone Oct 11, 2022
@meganrogge meganrogge mentioned this pull request Oct 18, 2022
3 tasks
@meganrogge meganrogge removed this from the October 2022 milestone Oct 18, 2022
@alexdima
Copy link
Member

I've extracted some of the commits to #164030

@alexdima alexdima marked this pull request as ready for review October 19, 2022 14:48
@alexdima alexdima merged commit 2d08400 into main Oct 21, 2022
@alexdima alexdima deleted the merogge/acc branch October 21, 2022 10:27
@alexdima alexdima added this to the October 2022 milestone Oct 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Word wrap should not be disabled when accessibility is turned on
3 participants