Send breakpoint init requests in parallel #163250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfigurationDone request
connor4312
reviewed
Oct 11, 2022
| // If sending breakpoints to one session which we know supports the configurationDone request, can make all requests in parallel | ||
| if (session?.capabilities.supportsConfigurationDoneRequest) { | ||
| await Promise.all([ | ||
| ...distinct(this.model.getBreakpoints(), bp => bp.uri.toString()).map(bp => this.sendBreakpoints(bp.uri, false, session)), |
There was a problem hiding this comment.
Could store the Promise<void>[] for this in a variable to use in both places and avoid duplicating, since it's somewhat complex
connor4312
previously approved these changes
Oct 11, 2022
TylerLeonhardt
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #163248