Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: View scalability #16326

Closed
3 tasks done
bpasero opened this issue Dec 1, 2016 · 1 comment
Closed
3 tasks done

Test: View scalability #16326

bpasero opened this issue Dec 1, 2016 · 1 comment
Assignees
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Dec 1, 2016

Test for #15155:

Complexity: 4

In order to support scenarios where extensions contribute viewlets to the activity bar, some work was done to enable scalability in the activity bar.

Setup:

Verify

  • you can show the contributed viewlet by
    • using the new View > Additional Viewlets entry
    • right clicking on empty space in activity bar and selecting it
    • by using the new view picker (quick open -> type "view " with a trailing space)
  • if you make the window small enough, viewlets that do not fit the space move into a new "..." overflow menu
    • entries in the overflow menu still indicate activity as decoration to their label
    • the current active viewlet is indicated in the overflow menu if inside
  • you can move viewlets around via DND and the position is remembered between restarts
  • you can remove viewlets from the activity bar and bring them back by
    • unchecking them from the activity bar context menu
    • right clicking on the viewlet and pick the related action to remove
    • removed viewlets still show up at the end of all viewlets when they are active but hide once another viewlet opens
  • you can bring back a removed viewlet either by
    • using the context menu on the empty space of activity bar
    • by opening it and from the context menu select the related entry to keep it

Verify some corner cases where you combine:

  • overflow of viewlets so you see the "..."
  • reordering of viewlets
  • keeping/removing viewlets

Watch out for crashes in the console in that case, there may well be some layouting bugs 👍

@seanmcbreen
Copy link

Looked good to me found some minor issues attached to this.

@bgashler1 bgashler1 assigned bpasero and unassigned bgashler1 Dec 7, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants