Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add diff editor navigation tip to aria label #163368

Merged
merged 2 commits into from Oct 12, 2022
Merged

add diff editor navigation tip to aria label #163368

merged 2 commits into from Oct 12, 2022

Conversation

meganrogge
Copy link
Contributor

fix #158929

@meganrogge meganrogge self-assigned this Oct 11, 2022
@meganrogge meganrogge added this to the October 2022 milestone Oct 11, 2022
@meganrogge
Copy link
Contributor Author

Should we only show this once so as not to annoy every time a diff view is opened? 🤔

@isidorn
Copy link
Contributor

isidorn commented Oct 12, 2022

Hmm for now I would say let's read it every time. The good thing is that it is at the end of the label, so users can skip over it.
In the future we can optimise.

@meganrogge meganrogge merged commit 3ddce05 into main Oct 12, 2022
@meganrogge meganrogge deleted the merogge/aria-diff branch October 12, 2022 21:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isidorn isidorn isidorn approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
October 2022
Development

Successfully merging this pull request may close these issues.

Diff editor - aria label should advertise the use of F7 / shift + F7
2 participants
@meganrogge @isidorn