Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add open preview enabled context, part 2 #163682

Merged
merged 4 commits into from Oct 17, 2022
Merged

Add open preview enabled context, part 2 #163682

merged 4 commits into from Oct 17, 2022

Conversation

joshaber
Copy link
Member

@joshaber joshaber commented Oct 14, 2022 •
edited

Follow up to #160898.

Also enable the "Preview in editor" choice for the toast in the web when the context key is enabled.

@mjbvz mjbvz assigned alexr00 and unassigned mjbvz Oct 14, 2022
alexr00
alexr00 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've just made a small change so that the context key is only created once.

@alexr00 alexr00 added this to the October 2022 milestone Oct 17, 2022
@alexr00 alexr00 enabled auto-merge (squash) October 17, 2022 18:35
@alexr00 alexr00 merged commit 38deb06 into microsoft:main Oct 17, 2022
@joshaber joshaber deleted the codespace-da9d branch October 17, 2022 19:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

@alexr00 alexr00 alexr00 approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
October 2022
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joshaber @rzhao271 @alexr00 @mjbvz