pwa-wco #164067
Merged
pwa-wco #164067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
approved these changes
Oct 20, 2022
jrieken
approved these changes
Oct 21, 2022
khaled200286
added a commit
to khaled200286/vscode
that referenced
this pull request
Oct 30, 2022
This reverts commit f68ccb9.
Closed
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this pull request
Nov 25, 2022
* pwa-wco * increase titlebar height with WCO as well * remove unused import * move to browser and fix compact menu case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding @joaomoreno and @jrieken as interested parties, btw I don't have my mac to make sure this is working there atm.
PWA with WCO:
Switches nicely to non-WCO mode: