merge editor telemetry #164254
Merged
merge editor telemetry #164254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
You may want to look into includes as this will help really reduce some of the duplicate properties which you share across events https://github.com/microsoft/vscode-telemetry-extractor/blob/main/documentation/typescript-code-annotations.md#Includes
|
|
||
| manuallySolvedConflictCountThatEqualNone: number; | ||
| manuallySolvedConflictCountThatEqualSmartCombine: number; | ||
| manuallySolvedConflictCountThatEqualInput1: number; |
There was a problem hiding this comment.
I wonder if you could use a shared type for this so that the args and the data type being sent from telemetry don't need to be duplicated
| owner: 'hediet'; | ||
| comment: 'This event tracks when the user navigates to the previous conflict".'; | ||
| }>('mergeEditor.action.goToPreviousConflict', { | ||
|
|
| owner: 'hediet'; | ||
| comment: 'This event tracks when the user navigates to the next conflict".'; | ||
| }>('mergeEditor.action.goToNextConflict', { | ||
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.