Wait for preload scripts before loading renderers #164406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
requested changes
Oct 24, 2022
| @@ -1318,7 +1318,8 @@ async function webviewPreloads(ctx: PreloadContext) { | |||
| } | |||
|
|
|||
| this._api = await module.activate(this.createRendererContext()); | |||
|
|
|||
| // Preloads need to be loaded before loading renderers. | |||
| await kernelPreloads.waitForAllCurrent(); | |||
There was a problem hiding this comment.
I think this should happen at the start of this function (before the import and activate)
DonJayamanne
force-pushed
the
issue164304
branch
from
2135855
to
3db3962
Compare
DonJayamanne
force-pushed
the
issue164304
branch
from
3db3962
to
1c69696
Compare
mjbvz
approved these changes
Oct 24, 2022
formigoni
pushed a commit
to formigoni/vscode
that referenced
this pull request
Oct 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164304