Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test verifying signed extensions #164452

Closed
8 tasks done
sandy081 opened this issue Oct 24, 2022 · 9 comments
Closed
8 tasks done

Test verifying signed extensions #164452

sandy081 opened this issue Oct 24, 2022 · 9 comments

Comments

@sandy081
Copy link
Member

sandy081 commented Oct 24, 2022

Refs: #162284

Complexity: 3

Create Issue


Set Up

Enable extension sign verification by adding following settings

"extensions.verifySignature": true,
"_extensionsGallery.enablePPE": true

Restart insiders.

Note: Do not forget to remove this setting _extensionsGallery.enablePPE after testing, so that you can use actual Marketplace.

Testing

Do not test installing regular extensions - this is expected to not work due to this setup. Only try with the extensions below.

@rzhao271 rzhao271 added this to the October 2022 milestone Oct 24, 2022
@weinand
Copy link
Contributor

weinand commented Oct 24, 2022

@sandy081 since I don't have access to an macOS ARM, I've removed my assignment

@isidorn
Copy link
Contributor

isidorn commented Oct 25, 2022

This test plan item is NOT yet ready for testing. We are waiting for a Marketplace deployment that should ideally happen by tomorrow. I will update the test plan item as we get updates from the marketplace team. Sorry about this.

@isidorn
Copy link
Contributor

isidorn commented Oct 25, 2022

This test plan item will be ready for testing on Wednesday (or if we get the next VS Code insiders before that). Sorry about the delay.

@paulacamargo25 paulacamargo25 removed their assignment Oct 26, 2022
@paulacamargo25
Copy link
Contributor

Tomorrow I go on vacation so I won't be able to test the TPI.

@sandy081
Copy link
Member Author

Latest insiders is available now and you can test it now. Thanks.

@jrieken

This comment was marked as outdated.

@isidorn
Copy link
Contributor

isidorn commented Oct 26, 2022

Update: make sure to only test the signed extensions that are listed in the test plan item.
It is expected that regular extension install does not work due to this weird setup.

@jrieken jrieken removed their assignment Oct 26, 2022
@joyceerhl
Copy link
Contributor

I was able to install all extensions on Windows x64 except nikhgup1.appmap123 due to version mismatch

2022-10-26 10:42:43.908 [error] Failed to install extension. nikhgup1.appmap123
2022-10-26 10:42:43.909 [error] Invalid: Cannot install 'nikhgup1.appmap123' extension because of version mismatch in Marketplace
    at $.checkAndGetCompatibleVersion (vscode-file://vscode-app/c:/Users/huer/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:87:96873)
    at async $.installFromGallery (vscode-file://vscode-app/c:/Users/huer/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:87:86770)

@sandy081
Copy link
Member Author

Thanks everyone for testing 👏

@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests