Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search performance. #16448

Closed
ssylvan opened this issue Dec 4, 2016 · 4 comments
Closed

Improve search performance. #16448

ssylvan opened this issue Dec 4, 2016 · 4 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@ssylvan
Copy link

ssylvan commented Dec 4, 2016

  • VSCode Version: 1.7
  • OS Version: Windows 10

Steps to Reproduce:

  1. Search for text in a large folder
  2. Open a cmd window and search for the same text using "findstr".
  3. Note how findstr is an order of magnitude faster.

Searching for stuff is a key operation. It shouldn't be this slow.

@chrmarti chrmarti added the search Search widget and operation issues label Dec 5, 2016
@chrmarti
Copy link
Contributor

chrmarti commented Dec 5, 2016

Improvements are in the upcoming 1.8. #15384

@chrmarti chrmarti closed this as completed Dec 5, 2016
@chrmarti chrmarti added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 5, 2016
@ssylvan
Copy link
Author

ssylvan commented Dec 5, 2016

FWIW, one way to improve the perceived performance could be to prioritize searches around "known" locations of the tree.

I often open up a huge folder because I want the context, but in practice I spend 99% of my time in some tiny sub-tree. When I search for something, the thing I want is probably going to be "near" some of my currently open files. Perhaps sorting the search order to prioritize folders that are close to currently opened files would mean that all the matches show up instantly (and I don't really care that it keeps searching the rest of the folder for another 10s after I've found what I wanted).

@chrmarti
Copy link
Contributor

chrmarti commented Dec 5, 2016

Good point, it would prevent us from showing the results in a deterministic order because the order we search depends on what files are/were open. /cc @roblourens

@roblourens
Copy link
Member

Interesting idea, also you should see faster search in Insiders now if you want to try it out.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

3 participants