Add note about built-in extensions #164601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
approved these changes
Oct 25, 2022
| @@ -15638,9 +15638,13 @@ declare module 'vscode' { | |||
|
|
|||
| /** | |||
| * Namespace for localization-related functionality in the extension API. To use this properly, | |||
| * you must have `l10n` defined in your `package.json` and have bundle.l10n.<language>.json files. | |||
| * you must have `l10n` defined in your extension manifest and have bundle.l10n.<language>.json files. | |||
There was a problem hiding this comment.
Do we use the term extension manifest in other places vs package.json?
| * For more information on how to generate bundle.l10n.<language>.json files, check out the | ||
| * [vscode-l10n repo](https://github.com/microsoft/vscode-l10n). | ||
| * | ||
| * Note: Built-in extensions (for example, Git, TypeScript Language Features, GitHub Authentication) |
There was a problem hiding this comment.
I'm wondering whether this should go in internal documentation somewhere- the intended reader of the vscode.d.ts might more be external extension authors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164565