Kill Terminal when only one terminal is open does not close the terminal panel

[joyceerhl]

In the current stable, when there is only one terminal in the terminal area, clicking Kill Terminal (the trash icon) would also minimize the panel. This is no longer the case in the latest insiders:

[meganrogge]

@joyceerhl anything else needed to repro this? does it always happen for you?

kill.mov

[joyceerhl]

Hm, if I start VS Code up with the panel visible, the first time it seems to close the panel as expected, then if I use ctrl+` to create a new terminal, on the second time onward it stops working.

terminal-maximize.mp4

I also see this error but unsure if it's related

this._core._renderService?._onIntersectionChange is not a function: TypeError: this._core._renderService?._onIntersectionChange is not a function
    at zi.forceUnpause (vscode-file://vscode-app/c:/Users/huer/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1971:27069)
    at Hi._resizeNow (vscode-file://vscode-app/c:/Users/huer/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:3121:3652)
    at Hi._resize (vscode-file://vscode-app/c:/Users/huer/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:3121:2736)
    at vscode-file://vscode-app/c:/Users/huer/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6:42864

[meganrogge]

oh that could certainly be related bc cannot repro and also not seeing that error on my computer. I have a PR to fix that error - will be interesting to see if you can repro tomorrow when that fix is in

[joyceerhl]

I won't be able to check on reproing this till after our stable 1.73 goes out because insiders tracks the release branch during debt week

[meganrogge]

@joyceerhl assuming it also reproduced in oss?

[VSCodeTriageBot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[Tyriar]

I expect this to be fixed in #164899

[joyceerhl]

Still repros for me.

Latest stable:

Latest insiders:

[Tyriar]

@joyceerhl I can't repro, any special steps/environment?

[meganrogge]

Cannot reproduce either

[joyceerhl]

Just Windows and Powershell. I can't repro if I disable all extensions, but extension bisect points to CPP Tools and I can still repro it after uninstalling CPP Tools so I doubt extension bisect is correct here. I do also see that the terminal initializes much faster if I have all extensions disabled. This seems flaky but eventually happens after killing the terminal a few times for me, could it be some kind of race condition?

[Tyriar]

Also reported at #163719

[meganrogge]

cpp tools is also present in the extension list reported in #163719

[Tyriar]

I'd be surprised if an extension could influence this

[thw0rted]

Have been experiencing this for a good couple of months now. I thought maybe I had misconfigured Git Bash (my default terminal) or something. It's good to hear other people have the same issue but looking back over this thread I don't really see a common denominator or any kind of workaround -- I just wind up clicking the "X" button on the terminal pane. It's annoying enough that I went looking for this issue; I'd sure like to at least have a way forward unless/until we figure out a root cause...

ETA: the "close pane" Command Palette option will close the orphaned Terminal pane, so that's something I guess.

[mistrate]

I'd be surprised if an extension could influence this

And you're right, I found the culprit to be https://github.com/gitkraken/vscode-gitlens. Uninstalling the extension fixes the issue, re-installing it brings the issue back

[thw0rted]

Good catch, do you think you could put together an issue for them? The only sort-of-related thing I could find is gitkraken/vscode-gitlens#2312 .

[VSCodeTriageBot]

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.

Happy Coding!

[Tyriar]

If an extension is to "blame" this issue is still our fault, the terminal panel should never show unless:

1. There is an active terminal, or
2. There is no terminal backend and the "welcome" message shows

[eamodio]

@Tyriar FWIW, Given the steps in gitkraken/vscode-gitlens#2691, I can only imagine that it is something related to the TerminalLinkProvider -- since that is the only thing GL does with the terminal without the user actually executing a small number of Git commands.

[Tyriar]

@eamodio that would surprise me unless there are exceptions in the console as that could interrupt disposal are there any exceptions, do you see any when this repros?

[eamodio]

I can't reproduce it.

[Tyriar]

Me neither 🤷

[Tyriar]

@joyceerhl let us know if you see something different

[thw0rted]

@Tyriar this still happens for me, reliably, every time. Is there some kind of debug output I can send to help you track it down? I agree that it should not be possible for an extension to break Code in this manner...

[Tyriar]

@thw0rted can you post your settings.json and list of extensions? You could try set log level to trace (via command palette) and then check the Output panel's "Window" log. Another place to check is whether any exceptions occur in the devtools console (Help > Toggle Developer Tools). Did you try with Insiders, or Stable?

[thw0rted]

Hey, sorry it took me so long to get back to this. I only run Stable release.

settings.json.txt

2023-05-31 10:30:29.242 [trace] KeybindingService#dispatch Ctrl+` workbench.action.terminal.toggleTerminal
2023-05-31 10:30:29.242 [trace] CommandService#executeCommand workbench.action.terminal.toggleTerminal
2023-05-31 10:30:29.253 [trace] terminalInstance#ctor (instanceId: 2) {"executable":"C:\\Program Files\\Git\\bin\\bash.exe","args":["--login"]}
2023-05-31 10:30:29.302 [trace] Webgl was loaded
2023-05-31 10:30:29.495 [debug] Terminal process ready (shellProcessId: 31456)
2023-05-31 10:30:29.506 [debug] terminalInstance added capability 3
2023-05-31 10:30:33.250 [debug] Terminal process exit (instanceId: 2) with code undefined
2023-05-31 10:30:33.250 [debug] Terminal process exit (instanceId: 2) state 6
2023-05-31 10:30:33.250 [trace] terminalInstance#dispose (instanceId: 2)
2023-05-31 10:30:36.099 [trace] CommandService#executeCommand workbench.action.closePanel
2023-05-31 10:30:38.764 [trace] KeybindingService#dispatch Ctrl+` workbench.action.terminal.toggleTerminal
2023-05-31 10:30:38.764 [trace] CommandService#executeCommand workbench.action.terminal.toggleTerminal
2023-05-31 10:30:38.795 [trace] terminalInstance#ctor (instanceId: 3) {"executable":"C:\\Program Files\\Git\\bin\\bash.exe","args":["--login"]}
2023-05-31 10:30:38.836 [trace] Webgl was loaded
2023-05-31 10:30:38.994 [debug] Terminal process ready (shellProcessId: 30052)
2023-05-31 10:30:39.001 [debug] terminalInstance added capability 3

That's the logs from opening a terminal with CTRL+backtick, exiting, closing the (now empty) bottom panel by clicking the "X" button, then opening a terminal (same kbd shortcut) again. Nothing jumps out at me.

[VSCodeTriageBot]

We closed this issue because we are unable to reproduce the problem with the steps you describe. Chances are we've already fixed your problem in a recent version of VS Code. If not, please ask us to reopen the issue and provide us with more detail. Our issue reporting guidelines might help you with that.

Happy Coding!

[mrroll]

I, too, am experiencing this. The only immediate thing for me is also having the GitLens extension.