Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Audio Cues (notebook cell completion) #165085

Closed
stauntonjr opened this issue Oct 31, 2022 · 5 comments · Fixed by #165442
Closed

add support for Audio Cues (notebook cell completion) #165085

stauntonjr opened this issue Oct 31, 2022 · 5 comments · Fixed by #165442
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders notebook-execution Issues related to running cells in a notebook on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@stauntonjr
Copy link

Is it possible to add the ability to configure an audio bell in vscode settings.json to sound upon completion of a cell in jupyter notebook? If so, is there any reason in particular this is not yet implemented or is it on the horizon? Thanks.

@stauntonjr stauntonjr added the feature-request Request for new features or functionality label Oct 31, 2022
@amunger amunger assigned roblourens and unassigned amunger Oct 31, 2022
@roblourens roblourens transferred this issue from microsoft/vscode-jupyter Oct 31, 2022
@roblourens roblourens added the notebook-execution Issues related to running cells in a notebook label Oct 31, 2022
@roblourens roblourens added this to the Backlog milestone Oct 31, 2022
@roblourens roblourens added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Oct 31, 2022
@roblourens
Copy link
Member

Looks like you are also assigned to Audio Cues issues @isidorn? If this is easy to adopt I could take a look with some pointers. Maybe the "taskCompleted" sound can be repurposed or would we need a new one?

@isidorn
Copy link
Contributor

isidorn commented Nov 1, 2022

I agree the task completed could be helpful here. Let me assign to @meganrogge for consideration
@roblourens it should be easy to adopt. You just use the audioCueService. Code pointer https://github.com/microsoft/vscode-distro/blob/6c2adaa1ab153382818ff972d16377cd3a101e25/src/vs/workbench/contrib/inlayHints/browser/inlayHintsAccessibilty.ts#L159

@isidorn isidorn assigned meganrogge and unassigned isidorn Nov 1, 2022
@meganrogge
Copy link
Contributor

@roblourens you could also use taskFailed if the cell fails to execute/complete

@roblourens roblourens added the help wanted Issues identified as good community contribution opportunities label Nov 2, 2022
@MonadChains
Copy link
Contributor

Hi everyone, I've open a PR with a possible implementation, let me know if it is helpful.

ps: @isidorn thank you for your code pointer

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 17, 2022
@rzhao271 rzhao271 modified the milestones: Backlog, November 2022 Nov 28, 2022
@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Nov 28, 2022
@alexr00 alexr00 added the verified Verification succeeded label Nov 30, 2022
@roblourens roblourens added the on-release-notes Issue/pull request mentioned in release notes label Dec 4, 2022
@elashrry
Copy link

I needed this feature but the implementation is for simple on/off switch. It would be nice if we can play sound only if the cell takes more than a pre-specified threshold. We don't need a sound for each cell, rather for the ones that take long time to run.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders notebook-execution Issues related to running cells in a notebook on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants