Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debt: move or remove NullXYZServices #165397

Merged
merged 1 commit into from Nov 3, 2022
Merged

debt: move or remove NullXYZServices #165397

merged 1 commit into from Nov 3, 2022

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Nov 3, 2022

We have a few NullXYZServices. Those are useful for testing but we should move them to separate files so that we don't end up shipping them with the product

We have a few NullXYZServices. Those are useful for testing but we should move them to separate files so that we don't end up shipping them with the product
@jrieken jrieken self-assigned this Nov 3, 2022
@jrieken jrieken enabled auto-merge (squash) November 3, 2022 17:13
@VSCodeTriageBot VSCodeTriageBot added this to the November 2022 milestone Nov 3, 2022
@@ -6,8 +6,3 @@
version "16.11.33"
resolved "https://registry.yarnpkg.com/@types/node/-/node-16.11.33.tgz#566713b1b626f781c5c58fe3531307283e00720c"
integrity sha512-0PJ0vg+JyU0MIan58IOIFRtSvsb7Ri+7Wltx2qAg94eMOrpg4+uuP3aUHCpxXc1i0jCXiC+zIamSZh3l9AbcQA==

vscode-nls@^5.2.0:
version "5.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change meant to be included?

@jrieken jrieken merged commit e8eb39b into main Nov 3, 2022
@jrieken jrieken deleted the joh/miniature-wren branch November 3, 2022 17:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants