Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close, minimize and maximize buttons missing on Arch Linux #165481

Closed
D3vil0p3r opened this issue Nov 4, 2022 · 8 comments
Closed

Close, minimize and maximize buttons missing on Arch Linux #165481

D3vil0p3r opened this issue Nov 4, 2022 · 8 comments
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug titlebar VS Code main title bar issues verified Verification succeeded
Milestone

Comments

@D3vil0p3r
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.73.0
  • OS Version: Arch Linux (Linux x64 6.0.2-arch1-1)
    image

I read several issues related the missing of close, maximize and minimize buttons occurring in Windows and macOS. I'm noting the same issue is happening also on Arch Linux.

Here, I have a full upgraded Arch Linux environment and when I open Code, I don't get these buttons:
image

This issue should be related to Electron19 because, when I downgrade electron19 package from 19.1.4 to 19.0.13, I get the three buttons:

image

Steps to Reproduce:

  1. On a full upgraded Arch Linux environment, install code by sudo pacman -Syy code
  2. Open the software by code
  3. When Code is opening, the three buttons on the top-right are missing
  4. Try now to downgrade electron19 package to 19.0.13 by using sudo downgrade electron19 and choosing the 19.0.13 version
  5. Reopen Code and the three buttons should appear
@Nuc1eoN
Copy link

Nuc1eoN commented Nov 8, 2022

Same here on arch:
2022-11-08_19:31:53

@major-mayer
Copy link

I can also confirm this

Version: 1.73.0
Commit: 8fa188b2b301d36553cbc9ce1b0a146ccb93351f
Date: 2022-11-03T14:04:08.642Z
Electron: 19.1.4
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Linux x64 5.19.17-2-MANJARO
Sandboxed: No

@l0ud
Copy link

l0ud commented Nov 23, 2022

Can confirm. How can you even invent such bugs I don't know.

@bvobart
Copy link

bvobart commented Nov 24, 2022

I'm having the same problem on Manjaro (which is based on Arch)

Version: 1.73.1
Commit: 6261075646f055b99068d3688932416f2346dd3b
Date: 2022-11-14T09:01:30.462Z
Electron: 19.1.4
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Linux x64 6.0.8-1-MANJARO
Sandboxed: No

Apparently this happens on Linux, MacOS as well as Windows, as there are similar issues for MacOS and Windows.

The Windows issue also shows people using Electron 19.1 getting this problem, so it seems like the problem was introduced when moving from Electron 19.0.13 to 19.1.x. #165337 (comment) mentions setting "window.experimental.windowControlsOverlay.enabled": true as a fix, but that doesn't work for me.

Notably, the Windows issue has been closed with #165384, but I don't know if that also fixes it for Linux & MacOS and when that will be released in a stable version.

@sbatten Thanks for the PR, would you mind updating us on whether that also fixes the issue on Linux & MacOS? If so, when can we expect it to be released in a stable version?

@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug titlebar VS Code main title bar issues labels Nov 28, 2022
@sbatten sbatten self-assigned this Nov 28, 2022
@sbatten sbatten added this to the November 2022 milestone Nov 28, 2022
@sbatten
Copy link
Member

sbatten commented Nov 28, 2022

Can anyone in this thread verify that the issue still remains on the latest insiders on arch(-based) linux?

@major-mayer
Copy link

Just tested it with the build from today on Manjaro and indeed the issue seems to be fixed.
grafik
Version: 1.74.0-insider
Commit: ac084d7
Date: 2022-11-28T05:23:46.430Z
Electron: 19.1.6
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Linux x64 5.19.17-2-MANJARO
Sandboxed: Yes

@sbatten
Copy link
Member

sbatten commented Nov 28, 2022

@major-mayer thank you very much for the confirmation. This fix will make its way to the next stable release.

@sbatten sbatten closed this as completed Nov 28, 2022
@sbatten sbatten added verified Verification succeeded author-verification-requested Issues potentially verifiable by issue author labels Nov 28, 2022
@D3vil0p3r
Copy link
Author

I confirm too on Athena OS (Arch-based) the latest insiders version is working correctly:

image

@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug titlebar VS Code main title bar issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants