Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use regular width buttons for walkthrough steps #166664

Merged
merged 6 commits into from Nov 21, 2022
Merged

Use regular width buttons for walkthrough steps #166664

merged 6 commits into from Nov 21, 2022

Conversation

daviddossett
Copy link
Contributor

@daviddossett daviddossett commented Nov 18, 2022 •
edited

Ref #165846

Fixes #166663 if we choose to go for it.

CleanShot 2022-11-17 at 16 51 31

@VSCodeTriageBot VSCodeTriageBot added this to the November 2022 milestone Nov 18, 2022
esonnino
esonnino suggested changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@esonnino esonnino left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a 32px padding on the right side of class .gettingStartedDetailsContent
And remove a 32px padding right from the thumbnails :)

image

image

@daviddossett
Copy link
Contributor Author

Thanks @esonnino — I think we should fix this in a separate PR to keep this one scoped to just the buttons. This PR may not go in anyway since it's still under discussion 👍 Created one at #166675

bhavyaus
bhavyaus previously approved these changes Nov 18, 2022
View reviewed changes
@daviddossett daviddossett merged commit b1fd1ab into main Nov 21, 2022
@daviddossett daviddossett deleted the ddossett/internal-gull branch November 21, 2022 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@esonnino esonnino esonnino approved these changes

@bhavyaus bhavyaus bhavyaus left review comments

Assignees

@daviddossett daviddossett

Labels
None yet
Projects
None yet
Milestone
November 2022
Development

Successfully merging this pull request may close these issues.

Use regular button widths for walkthroughs?
4 participants
@daviddossett @bhavyaus @esonnino @VSCodeTriageBot