Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the telemetry API #166873

Merged
merged 4 commits into from Dec 15, 2022
Merged

Updates to the telemetry API #166873

merged 4 commits into from Dec 15, 2022

Conversation

lramos15
Copy link
Member

@lramos15 lramos15 commented Nov 21, 2022 •
edited

Updates telemetry API.

  • Moves options out to their own object
  • Adds the ability to ignore unhandled errors

@lramos15 lramos15 self-assigned this Nov 21, 2022
jrieken
jrieken previously approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some naming suggestions and some input for naming discussions for things I am not yet sure about

src/vscode-dts/vscode.proposed.telemetryLogger.d.ts Outdated Show resolved Hide resolved
src/vscode-dts/vscode.proposed.telemetryLogger.d.ts Outdated Show resolved Hide resolved
src/vscode-dts/vscode.proposed.telemetryLogger.d.ts Show resolved Hide resolved
@lramos15
Copy link
Member Author

Will merge after endgame as to not cause extensions to rush to update so close the code freeze

@lramos15 lramos15 added this to the December 2022 milestone Nov 28, 2022
@lramos15 lramos15 merged commit e49c628 into main Dec 15, 2022
@lramos15 lramos15 deleted the lramos15/parental-blackbird branch December 15, 2022 14:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

Assignees

@lramos15 lramos15

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lramos15 @jrieken