Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable WCO on all builds #167060

Merged
merged 1 commit into from Nov 23, 2022
Merged

Enable WCO on all builds #167060

merged 1 commit into from Nov 23, 2022

Conversation

rzhao271
Copy link
Contributor

Fixes #161218
Fixes #164397

@rzhao271 rzhao271 enabled auto-merge (squash) November 23, 2022 14:59
@rzhao271 rzhao271 self-assigned this Nov 23, 2022
@rzhao271 rzhao271 added this to the November 2022 milestone Nov 23, 2022
bpasero
bpasero approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, should the setting be renamed and not have experimental in its name anymore? I typically think of experimental settings as disabled by default or running behind a real experiment.

@rzhao271 rzhao271 merged commit 4222ce8 into main Nov 23, 2022
@rzhao271 rzhao271 deleted the rzhao271/reenable-wco branch November 23, 2022 15:14
@rzhao271 rzhao271 mentioned this pull request Nov 23, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

@sbatten sbatten Awaiting requested review from sbatten

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
November 2022
Development

Successfully merging this pull request may close these issues.

Layout control in the wrong place for RTL macOS Win 11 Windows Control Overlay Stopped Working With 1.71.2
2 participants
@rzhao271 @bpasero