Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add application.experimental.* to Settings UI #167746

Merged
merged 1 commit into from Nov 30, 2022
Merged

Add application.experimental.* to Settings UI #167746

merged 1 commit into from Nov 30, 2022

Conversation

rzhao271
Copy link
Contributor

Fixes #167498

@rzhao271 rzhao271 enabled auto-merge (squash) November 30, 2022 17:18
@rzhao271 rzhao271 self-assigned this Nov 30, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the November 2022 milestone Nov 30, 2022
Tyriar
Tyriar reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rzhao271 let's wait until December if this is just an extra devtools log

@Tyriar Tyriar disabled auto-merge November 30, 2022 17:22
@rzhao271 rzhao271 modified the milestones: November 2022, December 2022 Nov 30, 2022
@rzhao271
Copy link
Contributor Author

@Tyriar I forgot to add this to the PR description, but the issue is that the setting does not show up in the Settings UI table of contents, and because of that, users cannot search it up either. The devtools warning serves as a warning flag for those issues, ref #89261.

Tyriar
Tyriar approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me for November if it's an important bug 👌

@rzhao271 rzhao271 modified the milestones: December 2022, November 2022 Nov 30, 2022
@rzhao271 rzhao271 merged commit e841339 into main Nov 30, 2022
@rzhao271 rzhao271 deleted the rzhao271/application-expset branch November 30, 2022 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@connor4312 connor4312 connor4312 approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
November 2022
Development

Successfully merging this pull request may close these issues.

WARN SettingsEditor2: Settings not included in settingsLayout.ts: application.experimental.rendererProfiling
4 participants
@rzhao271 @Tyriar @connor4312 @VSCodeTriageBot