Restrict hover focus trap behaviour to Settings indicators #167756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
previously approved these changes
Nov 30, 2022
|
My new idea is to add feature flags that are off by default. Will post a smaller diff on this branch soon. |
rzhao271
force-pushed
the
rzhao271/revert-hover-trap
branch
from
4f5365f
to
c7f306e
Compare
rzhao271
changed the title
Tyriar
requested changes
Nov 30, 2022
Tyriar
approved these changes
Nov 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167520
This reverts commit dbe96ec.This PR adds a feature flag so that the new hover focus trap behaviour is enabled only for the Settings indicators.