Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require manifest.activationEvents to generate implicit events #167786

Merged
merged 1 commit into from Dec 1, 2022

Conversation

joyceerhl
Copy link
Contributor

Fixes #167512

@joyceerhl joyceerhl enabled auto-merge (squash) November 30, 2022 23:42
@joyceerhl joyceerhl self-assigned this Nov 30, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the November 2022 milestone Nov 30, 2022
@joyceerhl joyceerhl merged commit 329de94 into main Dec 1, 2022
@joyceerhl joyceerhl deleted the dev/joyceerhl/supreme-crow branch December 1, 2022 08:52
@alexdima
Copy link
Member

alexdima commented Dec 1, 2022

Nice!

@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit activation events - extension contributing a command does not get activated
3 participants