Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolving of fileWorkspaceFolderBasename variable #167983

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

ahlinc
Copy link
Contributor

@ahlinc ahlinc commented Dec 3, 2022

This PR add the fileWorkspaceFolderBasename variable that would be useful in launch.json and task.json configurations. Especially it will be useful to create dynamic launch configurations when a binary name equals to a project root folder name.

Closes #159795

@ahlinc
Copy link
Contributor Author

ahlinc commented Dec 3, 2022

@microsoft-github-policy-service agree

@ahlinc ahlinc changed the title feat: Add resolving of "fileWorkspaceFolderBasename" variable Add resolving of "fileWorkspaceFolderBasename" variable Dec 3, 2022
@ahlinc
Copy link
Contributor Author

ahlinc commented Dec 4, 2022

It can be verified with:

{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "echo",
            "type": "shell",
            "command": "echo",
            "args": ["${fileWorkspaceFolderBasename}"],
            "problemMatcher": []
        }
    ]
}

@ahlinc ahlinc changed the title Add resolving of "fileWorkspaceFolderBasename" variable Add resolving of fileWorkspaceFolderBasename variable Dec 7, 2022
meganrogge
meganrogge previously approved these changes Dec 14, 2022
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks

@meganrogge meganrogge assigned mjbvz and unassigned meganrogge Dec 14, 2022
@meganrogge meganrogge added this to the January 2023 milestone Dec 14, 2022
@meganrogge meganrogge self-assigned this Dec 14, 2022
@mjbvz mjbvz removed their assignment Dec 14, 2022
@meganrogge meganrogge modified the milestones: January 2023, February 2023 Jan 9, 2023
@ahlinc ahlinc force-pushed the feat/fileWorkspaceFolderBasename branch from c58956f to f60b277 Compare January 19, 2023 01:04
@meganrogge meganrogge modified the milestones: February 2023, March 2023 Feb 22, 2023
@ahlinc ahlinc force-pushed the feat/fileWorkspaceFolderBasename branch from f60b277 to b662976 Compare March 7, 2023 09:07
@meganrogge meganrogge modified the milestones: March 2023, April 2023 Mar 22, 2023
@ahlinc ahlinc requested a review from meganrogge March 31, 2023 20:24
@ahlinc ahlinc force-pushed the feat/fileWorkspaceFolderBasename branch from b662976 to 8687570 Compare March 31, 2023 20:25
@meganrogge meganrogge modified the milestones: April 2023, May 2023 Apr 21, 2023
@meganrogge meganrogge enabled auto-merge May 4, 2023 01:35
@meganrogge meganrogge removed this from the May 2023 milestone May 26, 2023
@meganrogge meganrogge added this to the June 2023 milestone May 26, 2023
@meganrogge meganrogge modified the milestones: June 2023, July 2023 Jun 27, 2023
@meganrogge meganrogge modified the milestones: July 2023, August 2023 Jul 26, 2023
@meganrogge meganrogge removed this from the September 2023 milestone Sep 27, 2023
@meganrogge meganrogge removed the request for review from mjbvz November 10, 2023 19:42
@meganrogge meganrogge merged commit d55a500 into microsoft:main Nov 10, 2023
6 checks passed
@ahlinc ahlinc deleted the feat/fileWorkspaceFolderBasename branch November 15, 2023 12:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "fileWorkspaceFolderBasename" variable to tasks
4 participants