Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to open both integrated terminal and external terminal with … #168879

Merged
merged 13 commits into from Apr 7, 2023

Conversation

weartist
Copy link
Contributor

@weartist weartist commented Dec 12, 2022

resolved #167688

@weartist
Copy link
Contributor Author

@Tyriar If we want to two different command,We may need two items?and if we need to hide dynamically when changing configurations, that might also need to save the reference for the call to dispose. I don't know if my thinking is right, the code is a bit ugly, if the idea is indeed like this, I will improve it, thanks!

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this is a good start 👍

@Tyriar Tyriar added this to the January 2023 milestone Dec 16, 2022
@weartist
Copy link
Contributor Author

weartist commented Jan 2, 2023

@Tyriar Because something delayed for a while, current logic is that there are only two commands, but I'm not sure how to run the remote test, need your help

@Tyriar
Copy link
Member

Tyriar commented Jan 6, 2023

@weartist to get a remote window you run the new testresolver window via the command palette, that creates a fake remote window that connects to the local machine.

@Tyriar Tyriar modified the milestones: January 2023, February 2023 Jan 6, 2023
@weartist
Copy link
Contributor Author

weartist commented Jan 9, 2023

@Tyriar
I made some modifications:
When in the local, select Integrated, there will be only show Integrated option, select external, only external, select both, both are shown. ps: if on Windows, the external option will be renamed Windows
When In remote, whichever one you select, there is only show integrated.
Do we need to consider the web option, in which case only Integrated is allowed, or is web equal to remote?

@weartist weartist requested a review from Tyriar February 1, 2023 05:23
@weartist
Copy link
Contributor Author

@Tyriar not sure if this modification is appropriate

@TylerLeonhardt TylerLeonhardt added the deferred Issues that were automatically moved out of the release milestone label Feb 22, 2023
@Tyriar Tyriar removed this from the March 2023 milestone Mar 22, 2023
@Tyriar Tyriar removed the deferred Issues that were automatically moved out of the release milestone label Mar 29, 2023
@Tyriar Tyriar added this to the April 2023 milestone Mar 29, 2023
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay, works great 👍

@Tyriar Tyriar enabled auto-merge March 29, 2023 15:03
@weartist
Copy link
Contributor Author

weartist commented Apr 6, 2023

@Tyriar seems that someone else needs to approve

@Tyriar
Copy link
Member

Tyriar commented Apr 7, 2023

Asked someone on team to review

@Tyriar Tyriar merged commit 1da1092 into microsoft:main Apr 7, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should be able to open both integrated terminal and external terminal with right click
6 participants