Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes editor-area terminals are not restored after quit #168887

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Fixes editor-area terminals are not restored after quit #168887

merged 2 commits into from
Dec 16, 2022

Conversation

jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Dec 12, 2022 •
edited

Fixes #168643

Regression from #165742

Problem is the order onWillShutdown event gets fired in terminalService, it could fire before TerminalEditorInput serialization happens which is also triggered by onWillShutdown event. so let's move that logic to the TerminalEditorInput itself as it's created much later, also remove shutdownPersistentProcessId as it was a workaround for this same issue

@jeanp413 jeanp413 mentioned this pull request Dec 12, 2022
Closed
@Tyriar Tyriar added this to the January 2023 milestone Dec 16, 2022
Tyriar
Tyriar approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

@Tyriar Tyriar merged commit cb1113a into microsoft:main Dec 16, 2022
@jeanp413 jeanp413 deleted the fix-168643 branch December 16, 2022 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

Editor-area terminals are not restored after quit on 1.74.0
3 participants
@jeanp413 @Tyriar @TylerLeonhardt